[release/13.0] Allow HostUrl to remap both address and port #12552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ReubenBond and
mitchdenny
as code owners
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12552Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12552" |
|
@danegsta Could you please add details on the template above plz? |
|
I added a blurb |
davidfowl
approved these changes
Nov 3, 2025
|
Marking this as approved as it is part of the experience for new container tunneling. @davidfowl and @danegsta, given it is marked as medium risk, any particular scenarios we should bash on to have a higher confidence on this? |
danegsta
approved these changes
Nov 4, 2025
davidfowl
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12521 to release/13.0
/cc @danegsta
Customer Impact
3 big ones:
WithOtlpExporterwe inject a HostUrl object that gets rewritten depending on if it's a container or not. With @karolz-ms tunneling changes we missed a case where both the host and port need to be rewritten. This makes that work (before we used to assume host.docker.internal so that wasn't necessary)Testing
Manual and unit tests updates.
Risk
Medium
Regression?
Somewhat